fix(cubejs-client-ngx): Configure package-level Lerna publish directory for Angular #9189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr:community
HaidarZ
force-pushed
the
fix/cubejs-client-ngx-publish
branch
11 times, most recently
from
e0de3a8 to
2b65231
Compare
HaidarZ
force-pushed
the
fix/cubejs-client-ngx-publish
branch
3 times, most recently
from
b41dcf7 to
def223c
Compare
HaidarZ
force-pushed
the
fix/cubejs-client-ngx-publish
branch
from
def223c to
eeb2729
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the
@cubejs-client/ngxpackage to explicitly define its Lerna publish directory at the package level. Previously, Lerna was publishing the entire dist folder instead of its contents, leading to module resolution issues when linking the package in Angular projects.Key changes include adding the
lerna.command.publish.directoryconfiguration inside the package’s package.json, ensuring that Lerna correctly publishes from the intended dist location.Reference: Lerna directory documentation