Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: PatchMeasure member expression #9218

Draft
wants to merge 25 commits into
base: master
Choose a base branch
from

Conversation

mcheshkov
Copy link
Member

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

[For example #12]

Description of Changes Made (if issue reference is not provided)

[Description goes here]

@mcheshkov mcheshkov force-pushed the patch-measure-member-expression branch 2 times, most recently from 011a583 to 8792910 Compare February 13, 2025 01:13
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 91.67438% with 90 lines in your changes missing coverage. Please review.

Project coverage is 83.63%. Comparing base (671bcdb) to head (6275676).

Files with missing lines Patch % Lines
...t/cubesql/cubesql/src/compile/engine/df/wrapper.rs 81.72% 55 Missing ⚠️
...sql/src/compile/rewrite/rules/wrapper/aggregate.rs 95.61% 16 Missing ⚠️
rust/cubesql/cubesql/src/transport/ext.rs 74.46% 12 Missing ⚠️
...t/cubesql/cubesql/src/compile/engine/udf/common.rs 87.75% 6 Missing ⚠️
rust/cubesql/cubesql/src/compile/rewrite/mod.rs 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9218      +/-   ##
==========================================
+ Coverage   83.57%   83.63%   +0.06%     
==========================================
  Files         227      227              
  Lines       81627    82388     +761     
==========================================
+ Hits        68216    68905     +689     
- Misses      13411    13483      +72     
Flag Coverage Δ
cubesql 83.63% <91.67%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcheshkov mcheshkov force-pushed the patch-measure-member-expression branch from 214a45a to 6275676 Compare February 13, 2025 17:02
if (s.path()) {
return [s.cube().name].concat(this.evaluateSymbolSql(s.path()[0], s.path()[1], s.definition()));
} else if (s.patchedMeasure?.patchedFrom) {
return [s.patchedMeasure.patchedFrom[0]].concat(this.evaluateSymbolSql(s.patchedMeasure.patchedFrom[0], s.patchedMeasure.patchedFrom[1], s.definition()));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's at least add the word Path to the name of the patchedFrom field (ideally, of course, make it a structure with cubeName and Name). Otherwise, every time we come across such a code fragment, we will have to go to the patchedMeasure definition to understand what patchedFrom and its 0th and 1st elements represent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants