-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: PatchMeasure member expression #9218
base: master
Are you sure you want to change the base?
Conversation
011a583
to
8792910
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9218 +/- ##
==========================================
+ Coverage 83.57% 83.63% +0.06%
==========================================
Files 227 227
Lines 81627 82388 +761
==========================================
+ Hits 68216 68905 +689
- Misses 13411 13483 +72
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…re member expressions
…de::generate_sql_for_expr
…de::generate_column_expr
214a45a
to
6275676
Compare
if (s.path()) { | ||
return [s.cube().name].concat(this.evaluateSymbolSql(s.path()[0], s.path()[1], s.definition())); | ||
} else if (s.patchedMeasure?.patchedFrom) { | ||
return [s.patchedMeasure.patchedFrom[0]].concat(this.evaluateSymbolSql(s.patchedMeasure.patchedFrom[0], s.patchedMeasure.patchedFrom[1], s.definition())); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's at least add the word Path
to the name of the patchedFrom
field (ideally, of course, make it a structure with cubeName and Name). Otherwise, every time we come across such a code fragment, we will have to go to the patchedMeasure definition to understand what patchedFrom
and its 0th and 1st elements represent
Check List
Issue Reference this PR resolves
[For example #12]
Description of Changes Made (if issue reference is not provided)
[Description goes here]