Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cubesql): Use pushdown-pullup scheme for FilterSimplifyReplacer #9278

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mcheshkov
Copy link
Member

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made (if issue reference is not provided)

This should avoid unexpected unifications of simplified expression in unrelated context. For example, same expression can be present in filter and projection, but due to over-unification in filters it can receive different representation in projection, and break aliases later, during extraction

…acer

This should avoid unexpected unifications of simplified expression in unrelated context. For example, same expression can be present in filter and projection, but due to over-unification in filters it can receive different representation in projection, and break aliases later, during extraction
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 97.02233% with 12 lines in your changes missing coverage. Please review.

Project coverage is 83.60%. Comparing base (1dfa10d) to head (7df76e1).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...besql/cubesql/src/compile/rewrite/rules/filters.rs 95.83% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9278      +/-   ##
==========================================
- Coverage   83.65%   83.60%   -0.05%     
==========================================
  Files         227      227              
  Lines       81773    82030     +257     
==========================================
+ Hits        68409    68584     +175     
- Misses      13364    13446      +82     
Flag Coverage Δ
cubesql 83.60% <97.02%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant