Skip to content

Conversation

MazterQyou
Copy link
Member

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made

This PR makes SET ROLE statement, in addition to updating the role variable, change the authentication context accordingly. Related tests are included.

Signed-off-by: Alex Qyoun-ae <4062971+MazterQyou@users.noreply.github.com>
@MazterQyou MazterQyou requested a review from a team as a code owner September 19, 2025 16:23
Copy link

codecov bot commented Sep 19, 2025

Codecov Report

❌ Patch coverage is 92.85714% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.66%. Comparing base (9243f4c) to head (10f704b).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
rust/cubesql/cubesql/src/compile/router.rs 87.09% 8 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9982   +/-   ##
=======================================
  Coverage   84.66%   84.66%           
=======================================
  Files         254      254           
  Lines       90271    90329   +58     
=======================================
+ Hits        76427    76478   +51     
- Misses      13844    13851    +7     
Flag Coverage Δ
cubesql 84.66% <92.85%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@KSDaemon KSDaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 LGTM!

@MazterQyou MazterQyou merged commit c1b69cb into master Sep 21, 2025
120 of 121 checks passed
@MazterQyou MazterQyou deleted the cubesql/set-role-change-user branch September 21, 2025 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants