Skip to content

fix(native): Be happy, don't panic #9983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(native): Be happy, don't panic #9983

wants to merge 2 commits into from
+46 −10

Conversation

ovr
Copy link
Member

@ovr ovr commented Sep 19, 2025 •
edited
Loading

@ovr ovr requested a review from a team as a code owner September 19, 2025 19:53
@ovr ovr requested a review from KSDaemon September 19, 2025 19:53
KSDaemon
KSDaemon approved these changes Sep 19, 2025
View reviewed changes
Copy link
Member

@KSDaemon KSDaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 LGTM!
Most of the all - I love the PR name :))))

@codecov Codecov
Copy link

codecov bot commented Sep 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.66%. Comparing base (9243f4c) to head (b4e30c8).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #9983   +/-   ##
=======================================
  Coverage   84.66%   84.66%           
=======================================
  Files         254      254           
  Lines       90271    90271           
=======================================
  Hits        76427    76427           
  Misses      13844    13844
Flag Coverage Δ
cubesql 84.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KSDaemon KSDaemon KSDaemon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ovr @KSDaemon