suno en pimeja li ken kule #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This turns the "system theme" button into a separate toggle, allowing a user to pick a specific light and dark theme that will be automatically switched between, rather than being stuck with the default light and dark themes.
I admit that the logic is slightly overcomplicated, but I think this behavior makes the most sense to me from a ux perspective. I'd definitely be open to cutting it back if needed, though.
One thing not currently included in this pull request is a way to migrate the user's previous preference (since it no longer uses the plain
nimi.li:themekey). I can also add that if needed.Screenshot:
