Merge pull request #157 from cuberite/PlayerSelectionChangedHook

Implemented OnPlayerSelectionChanged callback
cuberite · Aug 4, 2024 · dd99ca6 · dd99ca6
2 parents 72ab743 + 6fb98c1
commit dd99ca6
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/Api/Manage.lua b/Api/Manage.lua
@@ -12,8 +12,10 @@ g_Hooks = {
 	["OnAreaChanged"]             = {}, -- Signature: function(a_AffectedAreaCuboid, a_Player, a_World, a_Operation)
 	["OnAreaCopied"]              = {}, -- Signature: function(a_Player, a_World, a_CopiedAreaCuboid)
 	["OnAreaCopying"]             = {}, -- Signature: function(a_Player, a_World, a_CopiedAreaCuboid)
-	["OnPlayerSelectionChanging"] = {}, -- Signature: function(a_Player, a_PosX, a_PosY, a_PosZ, a_PointNr)
-	["OnPlayerSelectionChanged"]  = {}, -- Signature: function(a_Player, a_PosX, a_PosY, a_PosZ, a_PointNr)
+	["OnPlayerSelectionChanged"]  = {}, -- Signature: function(a_Player, a_Cuboid, a_PointNr)  a_PointNr is nil if the entire selection changed.
+
+	-- Not implemented
+	["OnPlayerSelectionChanging"] = {}, -- Signature: function(a_Player, a_Cuboid, a_PointNr)  a_PointNr is nil if the entire selection changed.
 }
 
 

diff --git a/Classes/PlayerSelection.lua b/Classes/PlayerSelection.lua
@@ -334,7 +334,14 @@ end
 -- a_PointChanged is optional, assigned to the point that has just changed
 -- If nil, the entire selection is assumed changed
 function cPlayerSelection:NotifySelectionChanged(a_PointChanged)
-	-- TODO: Call the registered callbacks
+	-- TODO: Call the OnPlayerSelectionChangING callback to prevent selection changes.
+
+	-- Call the player selection changed callback to notify other plugins of the selection change.
+	self.PlayerState:DoWithPlayer(function(a_Player)
+		local cuboid = cCuboid()
+		cuboid:Assign(self.Cuboid)
+		CallHook("OnPlayerSelectionChanged", a_Player, cuboid, a_PointChanged)
+	end);
 
 	-- Set the player's WECUI, if present:
 	if (self.PlayerState.IsWECUIActivated) then