Skip to content

Conversation

@Snuffy2
Copy link
Contributor

@Snuffy2 Snuffy2 commented Nov 23, 2025

This pull request focuses on code quality improvements in the scripts folder, applying linting, formatting, and restructuring to align with the project's standards outlined in AGENTS.md.

Key Changes:

Enhanced llm_health_dashboard.py:

  • Added comprehensive type annotations using modern Python 3.11+ syntax (e.g., list[ModelData] instead of List[ModelData])
  • Added detailed NumPy-style docstrings to all functions and classes
  • Replaced print() statements to stderr with logger.error() using loguru
  • Improved import organization and added missing imports (e.g., collections.abc.Generator)
  • Enhanced error handling and code structure

Restructured Test Suite:

  • Moved scripts/test_llm_contracts.py to test_llm_contracts.py
  • Converted the standalone test script to use pytest framework with proper fixtures and test methods
  • Added integration test markers and server availability checks
  • Improved type annotations and docstrings throughout
  • Added init.py with package documentation

These changes bring the scripts folder in line with the project's coding standards, improving code quality, type safety, and testability without altering core functionality.

@Snuffy2 Snuffy2 force-pushed the Linting/Formatting-of-scripts-folder branch from 73478e2 to 485e409 Compare November 30, 2025 02:28
@Snuffy2 Snuffy2 force-pushed the Linting/Formatting-of-scripts-folder branch from 485e409 to 2873840 Compare November 30, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant