Skip to content
This repository was archived by the owner on May 28, 2019. It is now read-only.

Conversation

@sponte
Copy link

@sponte sponte commented Feb 1, 2016

Removing Rcov from rake task as it causes a build to break. Given @aslakhellesoy is working on gherkin3 there is not much point fixing this.

The only reason I am raising this pull request is to build current version of gherkin which fixes propagating tags in example groups to Before hooks in cucumber-jvm.

@sponte
Copy link
Author

sponte commented Feb 1, 2016

Hi @aslakhellesoy, I have "fixed" gherkin2 build by removing rcov and fixing bundler version to work properly on travis. It builds successfully now in CI. I know there is big push for gherkin3 but this build willl fix a bug with example tables and tags not being propagated to before/after hooks.

Do you have a separate release process for bumping versions up? I haven't touched any of the version files in the source. Let me know and I can update PR if required.

Best regards,
Stan

@aslakhellesoy
Copy link
Contributor

Hi @sponte we won't be making any more releases of gherkin2.

Cucumber-ruby uses gherkin3 now, and Cucumber-JVM, Cucumber-JS and SpecFlow are being updated to gherkin3 too.

@aslakhellesoy
Copy link
Contributor

Is there a bug report anywhere in Cucumber-JVM explaining what's wrong with example tables and tags not being propagated to hooks and how to reproduce it?

Do you believe #286 (which is currently not released) fixes this?

@sponte
Copy link
Author

sponte commented Feb 2, 2016

Yes. This PR fixes the issue. It was already implemented but never released hence I was trying to fix the build.

On 2 Feb 2016, at 07:00, Aslak Hellesøy notifications@github.com wrote:

Is there a bug report anywhere in Cucumber-JVM explaining what's wrong with example tables and tags not being propagated to hooks and how to reproduce it?

Do you believe #286 (which is currently not released) fixes this?


Reply to this email directly or view it on GitHub.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants