Skip to content

Commit

Permalink
[.NET] Update target frameworks (#265)
Browse files Browse the repository at this point in the history
- Drop .NET 7 from test matrix
- Replace .NET 6 to .NET 8. because .NET 6 will reach End of Support on November 12, 2024
- Update C# language version to 12

- .NET 7 is out of support. https://devblogs.microsoft.com/dotnet/dotnet-7-end-of-support/
- .NET 6 (LTS) will reach End of Support on November 12, 2024 https://devblogs.microsoft.com/dotnet/dotnet-6-end-of-support/
  • Loading branch information
Romfos authored Aug 15, 2024
1 parent 87213be commit 3970e02
Show file tree
Hide file tree
Showing 8 changed files with 8 additions and 9 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/test-dotnet.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,6 @@ jobs:
- uses: actions/setup-dotnet@v4
with:
dotnet-version: |
6.0.x
7.0.x
8.0.x
- run: dotnet test
working-directory: dotnet
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ This document is formatted according to the principles of [Keep A CHANGELOG](htt
## [Unreleased]
### Changed
- [Ruby] Upgraded messages support to permit up to v26
- [.NET] Drop unsupported frameworks. Now supported target frameworks are .NET 8, .NET Framework 4.6.2, .NET Standard 2.0

## [29.0.0] - 2024-08-12
### Added
Expand Down
2 changes: 1 addition & 1 deletion dotnet/Directory.Build.props
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project>

<PropertyGroup>
<LangVersion>11</LangVersion>
<LangVersion>12</LangVersion>
</PropertyGroup>

</Project>
2 changes: 1 addition & 1 deletion dotnet/Gherkin.Specs/Gherkin.Specs.csproj
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFrameworks>net8.0;net7.0;net6.0</TargetFrameworks>
<TargetFrameworks>net8.0</TargetFrameworks>
<OutputType>Exe</OutputType>
<StartupObject>Gherkin.Specs.CLI.Program</StartupObject>
</PropertyGroup>
Expand Down
2 changes: 1 addition & 1 deletion dotnet/Gherkin/Gherkin.csproj
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFrameworks>net6.0;netstandard2.0;net462</TargetFrameworks>
<TargetFrameworks>net8.0;netstandard2.0;net462</TargetFrameworks>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
<NoWarn>1591</NoWarn>
<Deterministic Condition="'$(Configuration)' == 'Release'">false</Deterministic>
Expand Down
4 changes: 2 additions & 2 deletions dotnet/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,10 @@ clean: ## Remove all build artifacts and files generated by the acceptance tests

acceptance: .built $(TOKENS) $(ASTS) $(PICKLES) $(ERRORS) $(SOURCES) ## Build acceptance test dir and compare results with reference

.built: $(SOURCE_FILES) Gherkin.Specs/bin/Debug/net6.0/Gherkin.Specs.dll
.built: $(SOURCE_FILES) Gherkin.Specs/bin/Debug/net8.0/Gherkin.Specs.dll
touch $@

Gherkin.Specs/bin/Debug/net6.0/Gherkin.Specs.dll:
Gherkin.Specs/bin/Debug/net8.0/Gherkin.Specs.dll:
dotnet test

$(GHERKIN_PARSER): $(GHERKIN_RAZOR) ../gherkin.berp
Expand Down
2 changes: 1 addition & 1 deletion dotnet/bin/gherkin
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/usr/bin/env bash
set -euf -o pipefail

arch="net6.0"
arch="net8.0"

dotnet "Gherkin.Specs/bin/Debug/$arch/Gherkin.Specs.dll" events "${@:1}"
2 changes: 1 addition & 1 deletion dotnet/bin/gherkin-generate-tokens
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/usr/bin/env bash
set -euf -o pipefail

arch="net6.0"
arch="net8.0"

dotnet "Gherkin.Specs/bin/Debug/$arch/Gherkin.Specs.dll" tokens "${@:1}"

0 comments on commit 3970e02

Please sign in to comment.