Skip to content

Commit

Permalink
[Ruby] - Messages update / skeleton for refactoring (#259)
Browse files Browse the repository at this point in the history
* Bump max messages version

* New changelog update

* Fix ref to ID Generator

* Fix up reference to initialize having wrong ref to idgenerator

* Fix up razor template

* Minor tidy of rakefile and remove capture warnings

* Rubocop TODO and warning about excessive refactoring yet!

* Fix gherkin bin file

* Tidy up ruby gemspec and set minimum version to 3.0

* Fix the generation of TODO to pass through correct ruby version

* Release using v3.3

* Alter test matrix to remove invalid rubies and test on newer rubies

* Set minimum messages requirement in gherkin owing to new bin path for id helpers

* Use spec_helper

* Tidy up query spec

* Remove legacy ref for rake

* Remove travis refs

* Add changelog
  • Loading branch information
luke-hill authored Jul 24, 2024
1 parent e439eb1 commit 5061942
Show file tree
Hide file tree
Showing 22 changed files with 792 additions and 175 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/release-rubygem.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
- uses: actions/checkout@v4
- uses: ruby/setup-ruby@v1
with:
ruby-version: '3.2'
ruby-version: '3.3'
bundler-cache: true
- uses: cucumber/action-publish-rubygem@v1.0.0
with:
Expand Down
6 changes: 2 additions & 4 deletions .github/workflows/test-ruby.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,10 @@ jobs:
matrix:
os:
- ubuntu-latest
ruby: ['2.6', '2.7', '3.0', '3.1', '3.2']
ruby: ['3.0', '3.1', '3.2', '3.3']
include:
- os: macos-latest
ruby: '3.2'
ruby: '3.3'

steps:
- uses: actions/checkout@v4
Expand All @@ -38,9 +38,7 @@ jobs:
ruby-version: ${{ matrix.ruby }}
bundler-cache: true
working-directory: ruby

- run: bundle exec rake
working-directory: ruby

- run: make acceptance
working-directory: ruby
6 changes: 5 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ This document is formatted according to the principles of [Keep A CHANGELOG](htt
## [Unreleased]
### Added
- (i18n) Added Gujarati translation for "Rule" ([#249](https://github.com/cucumber/gherkin/pull/249))
- [Ruby] Skeleton to begin technical refactor of internals ([#259](https://github.com/cucumber/gherkin/pull/259))

### Fixed
- [.NET] Provide informative exception for trailing escapes in tables ([#245](https://github.com/cucumber/gherkin/pull/245))
Expand All @@ -20,6 +21,10 @@ This document is formatted according to the principles of [Keep A CHANGELOG](htt
- (i18n) Tamil "And" and "But" translations should have single trailing space ([#243](https://github.com/cucumber/gherkin/pull/243))
- Intermittent failure of cpp test jobs in CI ([#217](https://github.com/cucumber/gherkin/issues/217))

### Changed
- [Java, JavaScript, PHP, Go, Ruby] Upgraded messages to v25
- [Ruby] Update minimum ruby requirement from 2.5 to 3.0 ([#259](https://github.com/cucumber/gherkin/pull/259))

## [28.0.0] - 2024-02-15
### Added
- [Python] Added release workflow for releasing to Pypi ([#213](https://github.com/cucumber/gherkin/pull/213))
Expand All @@ -30,7 +35,6 @@ This document is formatted according to the principles of [Keep A CHANGELOG](htt
- [Python] Reuse the action cucumber/action-publish-pypi in release ([#220](https://github.com/cucumber/gherkin/pull/220))
- [Python] Removed duplicate code in markdown token matcher ([#205](https://github.com/cucumber/gherkin/pull/205))
- [Java, JavaScript, PHP, Go, Ruby] Upgraded messages to v24
- Upgraded messages to v22

## [27.0.0] - 2023-09-15
### Added
Expand Down
1 change: 1 addition & 0 deletions ruby/.rspec
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
--require spec_helper
--color
13 changes: 13 additions & 0 deletions ruby/.rubocop.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
inherit_from: .rubocop_todo.yml

inherit_mode:
merge:
- Exclude

AllCops:
NewCops: disable
# Keep this inline with the lowest ruby version in the gemspec
TargetRubyVersion: 3.0
# Display cop name / style guide references
DisplayCopNames: true
DisplayStyleGuide: true
Loading

0 comments on commit 5061942

Please sign in to comment.