Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require python >= 3.9 #325

Merged
merged 3 commits into from
Jan 12, 2025
Merged

Require python >= 3.9 #325

merged 3 commits into from
Jan 12, 2025

Conversation

youtux
Copy link
Contributor

@youtux youtux commented Nov 17, 2024

🤔 What's changed?

Python 3.8 is EOL, and the latest python is 3.13, so let's update the package metadata and the required python version to match that. We are testing already against python 3.9..3.13 anyway

⚡️ What's your motivation?

Keeping the codebase in sync with the latest supported python versions.

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)

♻️ Anything particular you want feedback on?

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

Python 3.8 is EOL, and the latest python is 3.13, so let's udpate the package metadata and the required python version to match that.
We are testing already against python 3.9..3.13 anyway
@luke-hill
Copy link
Contributor

This feels like a good thing to sync up with the C/Cpp changes which are also seemingly like breaking changes. Although the quantity of releases in gherkin they're nearly always breaking changes 😅

@mpkorstanje
Copy link
Contributor

mpkorstanje commented Jan 12, 2025

Looks good to me. @youtux is dropping a supported version considered a breaking change in the python ecosystem?

@youtux
Copy link
Contributor Author

youtux commented Jan 12, 2025

I wouldn’t call it a breaking change, but I believe most of the libs increase at least the minor version when they stop supporting a python version.

@mpkorstanje mpkorstanje merged commit 546f970 into main Jan 12, 2025
6 checks passed
@mpkorstanje mpkorstanje deleted the update-pythons branch January 12, 2025 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants