[c]: install headers under cucumber/gherkin/ and .cmake files under gherkin/ #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than installing all the C headers directly under e.g. `/usr/include`, put them in a subdirectory like `/usr/include/cucumber/gherkin`. This is *not* the same directory as the C++ headers, which have an extra `cucumber/` corresponding to the `cucumber::` C++ namespace, e.g. `/usr/include/cucumber/cucumber/gherkin/`. See cucumber/messages#267 (comment).
Rather than installing `.cmake` files directly under e.g. `/usr/lib/cmake`, put them in a subdirectory like `/usr/lib/cmake/gherkin`. C++ CMake files are currently installed under e.g. `/usr/lib/cmake/cucumber_gherkin`; I think the leading `cucumber_` corresponds to the `cucumber::` C++ namespace, which is why I have chosen just `gherkin` for the C CMake files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than installing all the C headers directly under e.g.
/usr/include, put them in a subdirectory like/usr/include/cucumber/gherkin.This is not the same directory as the C++ headers, which have an extra
cucumber/corresponding to thecucumber::C++ namespace, e.g./usr/include/cucumber/cucumber/gherkin/. See cucumber/messages#267 (comment).Rather than installing
.cmakefiles directly under e.g./usr/lib/cmake, put them in a subdirectory like/usr/lib/cmake/gherkin.C++ CMake files are currently installed under e.g.
/usr/lib/cmake/cucumber_gherkin; I think the leadingcucumber_corresponds to thecucumber::C++ namespace, which is why I have chosen justgherkinfor the C CMake files.These paths will be influenced by #345.
🤔 What's changed?
Install headers under the subdirectory
cucumber/gherkinwithin the target include directory rather than all at the top level. Install.cmakefiles under thegherkinsubdirectory within the targetcmakedirectory rather than all at the top level, which is more conventional.⚡️ What's your motivation?
The C API has a large number of header files with generic names like
event.handitem.hthat have a high risk of conflict in system-wide installations and therefore should not be installed directly in directories like/usr/include.See cucumber/messages#267 (comment) for discussion of the path scheme.
A review of
-develpackages installed on my Fedora system showed that installing.cmakefiles in a subdirectory of acmakedirectory as in this PR is much more conventional than installing all the.cmakefiles at the top level.🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
Confirm that the adjusted installation paths are the desired ones.
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.