Skip to content

III-6634 New approach to make labels optional #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 27, 2025
Merged

III-6634 New approach to make labels optional #449

merged 1 commit into from
May 27, 2025

Conversation

grubolsch
Copy link
Contributor

Fixed

  • I must have done something wrong with my previous PR because it turns out to not work. :-( this new approach does. sorry!

Ticket: https://jira.uitdatabank.be/browse/III-6634

@grubolsch grubolsch enabled auto-merge May 27, 2025 11:51
@JonasVHG
Copy link
Contributor

JonasVHG commented May 27, 2025 •
edited
Loading

I think the problem in your previoous PR was that common-labels.json still had a minItems of 1.
I think it would be better to change the file, instead of having 2 common-labels(-optional).json.

Edit: Resolved, 2 different files are needed.

@grubolsch grubolsch merged commit 40f1fe3 into main May 27, 2025
11 of 12 checks passed
@grubolsch grubolsch deleted the III-6634/make-labels-optional branch May 27, 2025 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonasVHG JonasVHG JonasVHG approved these changes

@LucWollants LucWollants Awaiting requested review from LucWollants LucWollants is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grubolsch @JonasVHG