Prevent message extractor from crash and log warning on obsolete migration #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szsoppa
reviewed
Feb 13, 2025
README.md
Outdated
| @@ -94,6 +94,7 @@ If you're working on an Elixir/Phoenix project and need to manage translations, | |||
| - Elixir (tested on 1.14.0) | |||
| - Phoenix (tested on 1.7.0) | |||
| - Ecto SQL (tested on 3.6) | |||
| - PostgreSQL 15 or newer | |||
There was a problem hiding this comment.
Is there also a requirement regarding the SQLite version?
szsoppa
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR logs warning in the console when it detects that there is a newer migration available.
It also fixes problem with MessageExtractor module crashing application on PostgreSQL migration version lower than 3 and SQLite3 lower than 2.