Skip to content

Allow -o and -O to be used without whitespaces (e.g.: -oNAME) #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sergiodj merged 1 commit into from
Feb 17, 2025
Merged

Allow -o and -O to be used without whitespaces (e.g.: -oNAME) #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions tests/tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,14 @@ testOutputFileName()
assertContains "Verify whether 'wcurl' correctly sets a custom output filename" "${ret}" 'test filename'
}

testOutputFileNameWithoutSpaces()
{
url='example.com'
ret=$(${WCURL_CMD} -o"test filename" ${url} 2>&1)
assertContains "Verify whether 'wcurl' correctly sets --output" "${ret}" '--output'
assertContains "Verify whether 'wcurl' correctly sets --output with the correct filename" "${ret}" 'test filename'
}

testOutputFileNameRepeatedOption()
{
url='example.com'
Expand Down
6 changes: 6 additions & 0 deletions wcurl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,12 @@ while [ -n "${1-}" ]; do
OUTPUT_PATH="${1}"
;;

-o*|-O*)
opt=$(printf "%s\n" "${1}" | sed 's/^-[oO]//')
HAS_USER_SET_OUTPUT="true"
OUTPUT_PATH="${opt}"
;;

--no-decode-filename)
DECODE_FILENAME="false"
;;
Expand Down