Skip to content

Don't percent-decode colons ":", and percent encode them when found #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samueloph merged 1 commit into from
Jan 6, 2026
Merged

Don't percent-decode colons ":", and percent encode them when found #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions tests/tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,27 @@ testUrlDecodingBackslashes()
assertContains "Verify whether 'wcurl' successfully uses the default filename when the URL ends with a slash" "${ret}" '--output filename%5Cwith%2Fbackslashes%5c%2f'
}

testUrlDecodingColon()
{
url='example.com/filename%3Awith%3Acolons%3a'
ret=$(${WCURL_CMD} ${url} 2>&1 | tr '\n' ' ')
assertContains "Verify whether 'wcurl' successfully uses the default filename when the URL ends with a slash" "${ret}" '--output filename%3Awith%3Acolons%3a'
}

testUrlEncodeColon()
{
url='example.com/filename:with:colons:'
ret=$(${WCURL_CMD} ${url} 2>&1 | tr '\n' ' ')
assertContains "Verify whether 'wcurl' successfully uses the default filename when the URL ends with a slash" "${ret}" '--output filename%3Awith%3Acolons%3A'
}

testUrlAllowColonWhenOutput()
{
url='example.com/filename:with:colons:'
ret=$(${WCURL_CMD} ${url} -o "i:want:colons:here" 2>&1 | tr '\n' ' ')
assertContains "Verify whether 'wcurl' successfully uses the default filename when the URL ends with a slash" "${ret}" '--output i:want:colons:here'
}

# Test decoding a bunch of different languages (that do not use the latin
# alphabet), we could split each language on its own test, but for now it
# does not make a difference.
Expand Down
6 changes: 4 additions & 2 deletions wcurl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,8 @@ readonly PER_URL_PARAMETERS="\
# characters.
# 2F = /
# 5C = \
readonly UNSAFE_PERCENT_ENCODE="%2F %5C"
# 3A = :
readonly UNSAFE_PERCENT_ENCODE="%2F %5C %3A"

# Whether to invoke curl or not.
DRY_RUN="false"
Expand Down Expand Up @@ -193,7 +194,8 @@ get_url_filename()
# If what remains contains a slash, there is a path; return it percent-decoded.
case "${hostname_and_path}" in
# sed to remove everything preceding the last '/', e.g.: "example/something" becomes "something"
*/*) percent_decode "$(printf %s "${hostname_and_path}" | sed -e 's,^.*/,,')" ;;
# sed to also replace ':' with the percent_encoded %3A
*/*) percent_decode "$(printf %s "${hostname_and_path}" | sed -e 's,^.*/,,' -e 's,:,%3A,g')" ;;
esac
# No slash means there was just a hostname and no path; return empty string.
}
Expand Down