univ token icon #396
Closed
univ token icon #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippe-git
requested changes
Apr 29, 2024
There was a problem hiding this comment.
There still seems to be an issue with your image:
An online converter also had issues opening it, so I'm not sure what's wrong with it, but you should try and opening it / saving it with another software and resubmit it until GitHub is able to display it properly
|
Hello again
So when you got the folder curve-assets/images/assets than when I have to Create new file? Commit and than upload the picture? Because doesn’t letting me to upload file, shows this uploads are disabled
Plese guide me trying to create a pool
… On Apr 29, 2024, at 5:28 AM, Philippe ***@***.***> wrote:
@philippe-git requested changes on this pull request.
There still seems to be an issue with your image:
image.png (view on web) <https://github.com/curvefi/curve-assets/assets/2307365/566470ba-1697-4bb8-b5eb-94b04746d2c0>
An online converter also had issues opening it, so I'm not sure what's wrong with it, but you should try and opening it / saving it with another software until GitHub is able to display it properly
—
Reply to this email directly, view it on GitHub <#396 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/APYENKWJTFZ4DL2DGX4IOJ3Y7Y4HBAVCNFSM6AAAAABG5HAKPGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMRYGM3TIOJYGA>.
You are receiving this because you authored the thread.
|
|
I think I got it right this time
Can you check.
Thanks for your time
… On Apr 29, 2024, at 5:28 AM, Philippe ***@***.***> wrote:
@philippe-git requested changes on this pull request.
There still seems to be an issue with your image:
image.png (view on web) <https://github.com/curvefi/curve-assets/assets/2307365/566470ba-1697-4bb8-b5eb-94b04746d2c0>
An online converter also had issues opening it, so I'm not sure what's wrong with it, but you should try and opening it / saving it with another software until GitHub is able to display it properly
—
Reply to this email directly, view it on GitHub <#396 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/APYENKWJTFZ4DL2DGX4IOJ3Y7Y4HBAVCNFSM6AAAAABG5HAKPGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMRYGM3TIOJYGA>.
You are receiving this because you authored the thread.
|
|
You did not, it wasn't in the right folder. But at least this time I had a valid image to work with, so I've moved it to the right folder and merged it (here #402), the icon is now live! Sorry it's convoluted if you're not used to git, don't hesitate to have someone else give you a hand next time you want to submit an icon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.