feat: new bands chart #1541
Open
feat: new bands chart #1541
+1,740
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
OnlyJousting
force-pushed
the
feat/new-bands-chart
branch
from
d4203d3 to
107ea7e
Compare
OnlyJousting
force-pushed
the
feat/new-bands-chart
branch
from
5d6f4c8 to
675ff9d
Compare
Collaborator
DanielSchiavini
left a comment
DanielSchiavini
left a comment
There was a problem hiding this comment.
I didn't manage to get through the PR yet, but I'm leaving a few ideas already
apps/main/src/llamalend/features/bands-chart/hooks/useProcessedBandsData.ts
Outdated
Show resolved
Hide resolved
apps/main/src/llamalend/features/bands-chart/hooks/useProcessedBandsData.ts
Outdated
Show resolved
Hide resolved
Comment on lines
+64
to
+78
| market && collateralTokenAddress | ||
| ? { | ||
| symbol: market.collateral_token.symbol, | ||
| address: collateralTokenAddress, | ||
| chain: networks[rChainId].id, | ||
| } | ||
| : undefined | ||
| const borrowToken = | ||
| market && borrowedTokenAddress | ||
| ? { | ||
| symbol: market.borrowed_token.symbol, | ||
| address: borrowedTokenAddress, | ||
| chain: networks[rChainId].id, | ||
| } | ||
| : undefined |
Collaborator
There was a problem hiding this comment.
Suggested change
| market && collateralTokenAddress | |
| ? { | |
| symbol: market.collateral_token.symbol, | |
| address: collateralTokenAddress, | |
| chain: networks[rChainId].id, | |
| } | |
| : undefined | |
| const borrowToken = | |
| market && borrowedTokenAddress | |
| ? { | |
| symbol: market.borrowed_token.symbol, | |
| address: borrowedTokenAddress, | |
| chain: networks[rChainId].id, | |
| } | |
| : undefined | |
| market && collateralTokenAddress && { | |
| symbol: market.collateral_token.symbol, | |
| address: collateralTokenAddress, | |
| chain: networks[rChainId].id, | |
| } | |
| const borrowToken = | |
| market && borrowedTokenAddress && { | |
| symbol: market.borrowed_token.symbol, | |
| address: borrowedTokenAddress, | |
| chain: networks[rChainId].id, | |
| } |
Contributor
Author
There was a problem hiding this comment.
they will return this type if I make that change
const collateralToken: "" | {
symbol: string;
address: string;
chain: INetworkName;
} | undefined
Collaborator
There was a problem hiding this comment.
argh this is ugly 😢 but I we actually don't need to check collateralTokenAddress, it will never be null, only market needs to be checked. And it could just be
Suggested change
| market && collateralTokenAddress | |
| ? { | |
| symbol: market.collateral_token.symbol, | |
| address: collateralTokenAddress, | |
| chain: networks[rChainId].id, | |
| } | |
| : undefined | |
| const borrowToken = | |
| market && borrowedTokenAddress | |
| ? { | |
| symbol: market.borrowed_token.symbol, | |
| address: borrowedTokenAddress, | |
| chain: networks[rChainId].id, | |
| } | |
| : undefined | |
| const chain = rChainId | |
| const collateralToken = market && { ...market.collateral_token, chain } | |
| const borrowToken = market && {...market.borrowed_token.symbol, chain } |
Collaborator
DanielSchiavini
left a comment
DanielSchiavini
left a comment
There was a problem hiding this comment.
Sorry, it's a huge PR so there is a lot to review. If you prefer comments as a PR please let me know
0xAlunara
reviewed
Nov 6, 2025
apps/main/src/llamalend/queries/market-liquidation-band.query.ts
Outdated
Show resolved
Hide resolved
| // Parsed bands balance type used in chart data | ||
| export type ParsedBandsBalances = { | ||
| borrowed: string | ||
| collateral: string |
Collaborator
There was a problem hiding this comment.
Should we use Decimal type here?
apps/main/src/llamalend/features/bands-chart/hooks/useProcessedBandsData.ts
Outdated
Show resolved
Hide resolved
apps/main/src/llamalend/features/bands-chart/hooks/useUserBandsPriceRange.ts
Outdated
Show resolved
Hide resolved
apps/main/src/llamalend/features/bands-chart/TooltipContent.tsx
Outdated
Show resolved
Hide resolved
| <TooltipItem title={t`Your share of band`}>{userBandShare}</TooltipItem> | ||
| <TooltipItem variant="subItem" title={collateralToken?.symbol}> | ||
| {formatAbbreviatedNumber(data.userBandCollateralAmount)} | ||
| {`${formatUsd(data.userBandCollateralValueUsd ?? 0)}`} |
Collaborator
There was a problem hiding this comment.
Showing $0 just because we don't have the token price seems incorrect.
Also, the template string is not needed here
Suggested change
| {`${formatUsd(data.userBandCollateralValueUsd ?? 0)}`} | |
| {formatUsd(data.userBandCollateralValueUsd ?? 0)} |
| const price = Number(oraclePrice) | ||
| if (!Number.isFinite(price)) return [] | ||
|
|
||
| return [createMarkLine(price, `${formatUsd(+oraclePrice)}`, 'end', palette.oraclePriceLineColor)] |
Collaborator
There was a problem hiding this comment.
Suggested change
| return [createMarkLine(price, `${formatUsd(+oraclePrice)}`, 'end', palette.oraclePriceLineColor)] | |
| return [createMarkLine(price, formatUsd(+oraclePrice), 'end', palette.oraclePriceLineColor)] |
| collateralTokenAddress, | ||
| borrowedTokenAddress, | ||
| }) | ||
| const collateralToken = |
Collaborator
There was a problem hiding this comment.
this conversion is repeated, it should be a helper somewhere
| ? { | ||
| symbol: llamma.collateralSymbol, | ||
| address: collateralTokenAddress, | ||
| chain: networks[chainId].id, |
Collaborator
There was a problem hiding this comment.
why do we need the networks mapping for this?
Suggested change
| chain: networks[chainId].id, | |
| chain: chainId, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new bands chart is available on market pages with BETA mode enabled.
Changes:
Still to do:
Add "bundle band"(will add at a later stage)(currently has placeholder)Add loading state (currently has placeholder)(will update at the same time as the candle chart)