Feat: improve llamalend slider #1553
Open
+971
−259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
0xPearce
changed the title
0xPearce
commented
Nov 6, 2025
0xPearce
commented
Nov 6, 2025
| format={formatUsd} | ||
| data={data} | ||
| adornment="dollar" | ||
| scale="power" |
Collaborator
Author
There was a problem hiding this comment.
Just to be sure, we are going with this scale. Try the llamalend filters
Collaborator
Author
There was a problem hiding this comment.
Tried to make it simpler, hope that's the case 😅. I can always reverted back to a simpler version without debounce
0xAlunara
reviewed
Nov 6, 2025
| ...sx, | ||
| ...(adornment === 'bands' && { | ||
| flexShrink: 0, | ||
| maxWidth: MaxWidth.sliderInput.bands, |
Collaborator
There was a problem hiding this comment.
Huh I would expect minWidth here to make sure it's wide enough to at least fill the adornment, not maxWidth :thinking_face:
| value={percentage ?? `${MIN_PERCENTAGE}`} | ||
| onChange={(value) => handlePercentageChange(value as Decimal)} | ||
| sliderProps={{ | ||
| 'data-rail-background': 'danger', |
Collaborator
There was a problem hiding this comment.
I don't think we want to hardcode this specific style for every instance of LTI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created
SliderInputcomponent on top of theSliderandNumericTextFieldReplace the slider + input components with the new one
Llamalend filters menu not automatically closing anymore
Implemented non-linear scale for inputs
Updated Slider stories + llamalend tests
show all poolsbutton when no marketsSliderandInputscomponent with all variantsSliderwithSliderInputTradingSliderand Bands slider withSliderInputNumericTextField