chore: return proper promises #1581
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…into chore/interval-await
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the removal of floating promises (void expressions) throughout the codebase by implementing proper error handling. The main changes include:
- Creates a new
errorFallbackutility function for centralized error handling - Removes
voidoperators from promise calls and adds.catch(errorFallback)instead - Updates function signatures to properly return
Promise<void>where needed - Applies throttling to frequently-called functions using a new
useThrottlehook - Refactors some Promise handling to use
Promise.all()for better performance - Simplifies conditional rendering patterns
- Minor CI workflow improvements
Reviewed Changes
Copilot reviewed 129 out of 130 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
packages/curve-ui-kit/src/utils/error.util.ts |
New error handler utility with ignored error patterns |
packages/curve-ui-kit/src/utils/timers.ts |
Adds useThrottle hook for throttling callbacks |
packages/curve-ui-kit/src/themes/design/0_primitives.ts |
Renames FormDebounce to FormThrottle with updated timing |
packages/curve-ui-kit/src/hooks/useLocalStorage.ts |
Adds shouldShowErrors helper function |
packages/curve-ui-kit/src/hooks/useDebounce.ts |
Updates default timing constant reference |
| Multiple store files | Replace void with .catch(errorFallback) pattern |
| Multiple component files | Update function signatures and add error handling |
.github/workflows/ci.yaml |
Improves artifact naming and configuration |
apps/main/src/loan/components/PageLoanManage/LoanDeleverage/index.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setFormValuesto make sure they aren't called too often