refactor: user positions table llamalend #1600
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… chips and visibilty settings
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
0xPearce
commented
Nov 3, 2025
| import { ArrowTopRightIcon } from '@ui-kit/shared/icons/ArrowTopRightIcon' | ||
|
|
||
| // TODO: move it to constants / links file | ||
| const LLAMA_MONITOR_BOT_URL = 'https://t.me/LlamalendMonitorBot' |
Collaborator
Author
There was a problem hiding this comment.
Is there a better place for this external link?
| export const UserPositionsTable = ({ result, loading, tab }: UserPositionsTableProps) => { | ||
| export const UserPositionsTable = ({ onReload, result, loading, tab }: UserPositionsTableProps) => { | ||
| const { markets: data = [], userHasPositions } = result ?? {} | ||
| const userData = useMemo(() => data.filter((market) => market.userHasPositions?.[tab]), [data, tab]) |
Collaborator
Author
There was a problem hiding this comment.
imo better to filter early by user positions instead of giving the table all the markets
Collaborator
Author
There was a problem hiding this comment.
Maybe should be moved to llama-markets.ts?
0xPearce
changed the title
0xPearce
commented
Nov 7, 2025
| } | ||
|
|
||
| // Enum for the empty state of the user positions table | ||
| export enum PositionsEmptyState { |
Collaborator
Author
There was a problem hiding this comment.
Should I create a different constants.ts or rename this one?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the User Positions Table for llamalend