fix: small pools filter showing at least 10 #1605
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
DanielSchiavini
force-pushed
the
fix/dex-small-pools
branch
from
bc2eb66 to
7f80400
Compare
| // migration from v1 to v2: add deprecated filter | ||
| migrate: (oldValue, initial) => [...initial.filter((i) => !oldValue.some((o) => o.id === i.id)), ...oldValue], | ||
| } | ||
| const migration: MigrationOptions<ColumnFiltersState> = { version: 2 } |
There was a problem hiding this comment.
no need for the migration anymore, we don't keep the defaultValues in local storage
…into fix/dex-small-pools
DanielSchiavini
requested review from
0xAlunara,
0xPearce,
0xtutti and
OnlyJousting
packages/curve-ui-kit/src/shared/ui/DataTable/hooks/useColumnFilters.tsx
Show resolved
Hide resolved
0xAlunara
left a comment
0xAlunara
left a comment
There was a problem hiding this comment.
I approved, but actually when going to https://curve-dapp-git-fix-dex-small-pools-curvefi.vercel.app/dex/plasma/pools?sort=-tvl I'm still seeing more than 10 pools, even though I've enabled "hide small pools" 🤔
It works for Ethereum, but not Plasma. Perhaps lite networks are treated differently?
EDIT: I'm trying other networks and it's just Plasma that doesn't seem to work, not sure what's going on here...
Well, the 10th pool there has 0 liquidity.. So all pools with the same liquidity are shown. I think that's kind of OK, because it would be pretty random to hide pools that have the same liquidity 🤔 and quite hard with the current solution. What do you think? |
Uh oh!
There was an error while loading. Please reload this page.