chore: speed-up typecheck #1609
Conversation
- yarn typecheck now type-checks apps and tests only. Since they import the libraries’ sources, the libs get checked transitively instead of being checked separately and then again from each app. - Use yarn typecheck:all when you specifically want to check every workspace independently
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| "lint": "eslint . --ext .ts,.tsx", | ||
| "lint:fix": "eslint . --ext .ts,.tsx --fix", | ||
| "typecheck": "yarn workspaces foreach --parallel --all run typecheck", | ||
| "typecheck": "yarn workspaces foreach --parallel --include main --include router-api --include tests run typecheck", |
There was a problem hiding this comment.
When running this command locally I get the following error:
This is the same error I get when removing --exclude curve-frontend from typecheck:all, which is probably why you added the exclude in the first place. However, if I add the same exclude to typecheck it's still failing for me.
This might be a Windows quirk, perhaps it's not happening on Mac (which is the OS you're using if I'm correct?)
There was a problem hiding this comment.
omg such a weird error 🙈
|
@copilot fix the typecheck and typecheck:all commands |
|
@DanielSchiavini I've opened a new pull request, #1622, to work on those changes. Once the pull request is ready, I'll request review from you. |
Uh oh!
There was an error while loading. Please reload this page.