fix: view contracts corrections #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: fiddyresearch <11488427+bout3fiddy@users.noreply.github.com>
4 tasks
fixtures changes were messing with the other tests
3 tasks
heswithme
pushed a commit
to heswithme/stableswap-ng
that referenced
this pull request
Sep 25, 2024
fix: view contracts corrections
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the correction suggested in #43 and #44.
For #43 in addition to the suggested correction
is_static_call=Truehad to be used to maintain the view function visibility.Some simple tests have been added for both cases. I've also started marking tests that were previously broken as expected to fail to lay the foundation for the improvements on the testing infrastructure.