Open
Conversation
mahmoud-elmorabea
force-pushed
the
feature/real-time-location
branch
from
51d0a0f to
fcfdf56
Compare
Sample app builds 📱Below you will find the list of the latest versions of the sample apps. |
mahmoud-elmorabea
force-pushed
the
feature/real-time-location
branch
from
a49e9cd to
b875a76
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1019 +/- ##
==========================================
- Coverage 68.86% 68.60% -0.27%
==========================================
Files 189 211 +22
Lines 10169 10944 +775
==========================================
+ Hits 7003 7508 +505
- Misses 3166 3436 +270 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SDK binary size reports 📊SDK binary size of this PRSDK binary size diff report vs. main branch |
mahmoud-elmorabea
force-pushed
the
feature/real-time-location
branch
from
b875a76 to
f3950aa
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
| commonLogger.moduleInitStart(module.moduleName) | ||
| module.initialize() | ||
| commonLogger.moduleInitSuccess(module.moduleName) | ||
| } |
There was a problem hiding this comment.
Module init success logged even when initialization fails
Low Severity
moduleInitSuccess is logged unconditionally after calling module.initialize(), but LocationModule.initialize() silently returns without initializing when called off the main thread (it only logs an error). This produces a misleading "init success" log message when the module actually failed to initialize, making debugging harder.
Additional Locations (1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Location enrichment feature, those are collection of approved PRs
Note
Medium Risk
Touches SDK initialization and DataPipeline identify/track flow by adding module initialization hooks and context enrichment, which could affect event payloads and startup behavior. Also adds new persisted location handling and sample app permissions/UI, increasing integration surface area.
Overview
Introduces a new optional
CioLocationmodule, including a publicCustomerIO.locationAPI, configurable tracking modes, persisted last-known location, and a guardrailed sync flow (24h + 1km) that tracks location updates only when a user is identified.Extends the core SDK to support pluggable modules via
SDKConfigBuilder.addModule(_:)and initializes them duringCustomerIO.initialize(withConfig:); adds a profile-enrichment system (registry + Identify plugin) so modules can inject primitive attributes into identify context and reset per-profile state.Updates distribution and samples to ship and exercise the new module: adds
CustomerIOLocationCocoaPod +CustomerIOsubspec and a SwiftPMLocationproduct/target/tests, wires the module into sample app initialization, adds a new Location Test screen and required location usage description, and updates CI/workflows and the Makefile to include the new pod/module.Written by Cursor Bugbot for commit f6ad0cf. This will update automatically on new commits. Configure here.