Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GlueStick training config #29

Merged
merged 7 commits into from
Nov 1, 2023
Merged

Conversation

rpautrat
Copy link
Member

@rpautrat rpautrat commented Oct 23, 2023

  • Update the batch, dataset size and iteration numbers.
  • Remove strict loading and unnecessary checks
  • Update the link to the preprocessed ETH3D dataset to specify that it came from the SOLD2 paper and it is not the original dataset.

Copy link
Collaborator

@iago-suarez iago-suarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR edits the training configuration of gluestick to match the one in the paper and, very importantly, updates the link of ETH3D undistorted images.

@iago-suarez iago-suarez merged commit 4a82835 into main Nov 1, 2023
2 checks passed
@iago-suarez iago-suarez deleted the rpautrat/fix-gluestick-config branch November 1, 2023 13:36
tompritch30 pushed a commit to tompritch30/glue-factory that referenced this pull request May 30, 2024
* Update training config of GlueStick

* Remove unnecessary checks in GlueStick

* Update ETH3D download link

* Update link to undistorted ETH3D

* Update link to download DeepLSD

---------

Co-authored-by: pautratr <pautratr@student.ethz.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants