Development #13
Merged
Development #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rename var skip_frames to update_delay - update_delay is now also how the frame UI is updated -> less UI blocking - can be changed during run time but should still not be set to 1
- better input handling - do not raise exceptions but log warnings - handle outputs interally better - update tests accordinlyg - depricate test for negative landmarks (which are now valid)
- check that enough values of auto thresholding are available - set "no threhsold" case to default to "complete" blink state
- inform the user about possible failure of auto threshold detection
- disentangle parameter checks and extraction logic - be more aggressive in error reporting - clean the code
- add information if some face frame is shown as preview - needed for investigation of misaligned shown frame and blink
- fix default parameters for smoothing - allow the graph to go to -0.05 on y range - fix smoothing issues - test file for 30FPS - add best default settings as comment
- if the video length is below one minute the summary now completes - always assume that there is now at least an unfinished minute in the video
- every algorithm setting parameters gets its own help button - create some button to show recommended extraction parameters
- make the content more informative that this is not wrong but was just not possible - also change from `warning` to `information`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include several improvements
Helpmenu to link to webpage, wiki, and license information