Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update counterfactual_metrics_demo.ipynb #98

Closed
wants to merge 1 commit into from
Closed

docs: update counterfactual_metrics_demo.ipynb #98

wants to merge 1 commit into from

Conversation

eltociear
Copy link

consine -> cosine

@dylanbouchard dylanbouchard changed the base branch from main to develop January 9, 2025 14:09
@dylanbouchard
Copy link
Collaborator

👋 @eltociear, thank you for creating this PR! Can you please confirm that you have signed the contributor license agreement?

@dylanbouchard dylanbouchard self-requested a review January 9, 2025 14:58
dylanbouchard
dylanbouchard requested changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@dylanbouchard dylanbouchard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After taking a look at this notebook, I noticed that "cosine similarity" is mentioned under BLEU and ROUGE-L sections as well. Can you please correct the language in those sections as well?

@dylanbouchard
Copy link
Collaborator

Closing this PR due to lack of activity. @eltociear I have tagged you #109, which addresses these issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylanbouchard dylanbouchard dylanbouchard requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eltociear @dylanbouchard