Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libtxproto: Add free'd callback on tx_io_register_cb #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

libtxproto: Add free'd callback on tx_io_register_cb #31

wants to merge 1 commit into from

Conversation

rofferom
Copy link
Contributor

@rofferom rofferom commented Apr 3, 2024

This will allow to free stuff inside the userdata.

@rofferom
libtxproto: Add free'd callback on tx_io_register_cb
d5b2a65 
This will allow to free stuff inside the userdata.
@cyanreg
Copy link
Owner

cyanreg commented Apr 5, 2024

Is there a specific need for this?
Userdata is meant to be some user context that users free themselves, as it is created before registering the callback.

@rofferom
Copy link
Contributor Author

rofferom commented Apr 8, 2024

Actually This will allow to free stuff inside the userdata. is a consequence of the patch. At first I wanted to be notified of the AVBufferRef * that is returned. It also allow to use the free callback to understand when the userdata isn't needed anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rofferom @cyanreg