Enable to set custom SSLContext #75
Conversation
There was a problem hiding this comment.
@vvidovic Thank you for the PR! Just a few comments on the code here.
I would like to see a few things added that are missing from here to get this into the codebase:
- Its usage in the README and updates to the API
- Updated CHANGELOG
- DCO signoff on your commit
PS: Mali svijet 😆
Added code enabling to set custom SSLContext from Java code during Conjur class initialization. SSLContext enables us to set up a trust between application and Conjur server from Java code. Usable in k8s/OpenShift environment to setup TLS trust with Conjur server dynamicaly from k8s secret and/or configmap data. README.md file updated with example setup of SSLContext and it's usage in different Conjur constructors. Signed-off-by: Vedran Vidovic <vvidovic@email.com>
|
Thanks for the review, please let me know if I missed something. |
The new SSLContext-based usage is more appropriate to have as first item in usage than JVM-level approach. Wording and nesting of headers was improved for readability too.
There was a problem hiding this comment.
Hey @vvidovic,
It looks good to me just needs a bit of wording change for which I've opened a pull request against your repo. If you merge that, I think this branch might be ready for inclusion (I may need to confirm this though).
Move SSLContext README section and improve wording
|
Code Climate has analyzed commit 9dc5f34 and detected 17 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
|
/approve-build 9dc5f34 |
1 similar comment
|
/approve-build 9dc5f34 |
|
Moved PR to a branch in parent repo and new PR has been opened for the code so that we can build it on internal infra: #76. Closing this PR. PS: I fixed up the comment from readme and removed the merge commit from my readme update in it. |
Added code enabling to set custom SSLContext from Java code during
Conjur class initialization.
Usable in k8s/OpenShift environment to setup TLS trust with Conjur
server dynamically from k8s secret and/or configmap data.
Connected to #74.