Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing hostfactory command examples #134

Merged
merged 1 commit into from
Apr 27, 2023
Merged

Conversation

szh
Copy link
Contributor

@szh szh commented Apr 27, 2023

Add usage examples to the help output for:

  • hostfactory tokens revoke
  • hostfactory hosts create

Connected Issue/Story

CyberArk internal issue ID: CNJR-1370

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: [insert issue ID]
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@szh szh added the kind/bug label Apr 27, 2023
@szh szh self-assigned this Apr 27, 2023
@szh szh requested a review from a team as a code owner April 27, 2023 18:16
@szh szh force-pushed the hostfactory-examples branch 2 times, most recently from 27491ba to 9cfb0f6 Compare April 27, 2023 18:22
@@ -50,6 +50,11 @@ func newHostsCreateCmd(clientFactory createHostClientFactoryFunc) *cobra.Command
hostsCreateCmd := &cobra.Command{
Use: "create",
Short: "Use a token to create a host",
Long: `Use a host factory tokens to create a host.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Long: `Use a host factory tokens to create a host.
Long: `Use a host factory token to create a host.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

@szh szh force-pushed the hostfactory-examples branch from 9cfb0f6 to 643adfb Compare April 27, 2023 20:06
@codeclimate
Copy link

codeclimate bot commented Apr 27, 2023

Code Climate has analyzed commit 643adfb and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 82.3% (0.0% change).

View more on Code Climate.

@szh szh merged commit 9845e7f into master Apr 27, 2023
@szh szh deleted the hostfactory-examples branch April 27, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants