Remove redhat-rpm-config package from UBI image #2577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This package is used for building RPMs, which we do don't in this image. This package also has conflicts with glibc that is causing current build issues.
|
An error occurred when fetching issues. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 89.9% (-1.5% change). View more on Code Climate. |
imheresamir
approved these changes
Jun 16, 2022
Contributor
imheresamir
left a comment
imheresamir
left a comment
There was a problem hiding this comment.
LGTM, thanks for fixing this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desired Outcome
The UBI Conjur image currently installs the
redhat-rpm-configpackage. This iscausing a current build failure because of
glibcversion conflicts. However, uponfurther investigation it appears this package is used for building RH RPMs. We
don't create RPMs in this image, so this package shouldn't be necessary.
Implemented Changes
Removed the
redhat-rpm-configpackage from the UBI Dockerfile.Connected Issue/Story
This is in support of:
#2565
Progress on that PR is currently blocked on the build failures caused
by this image build.
Definition of Done
At least 1 todo must be completed in the sections below for the PR to be
merged.
Changelog
CHANGELOG update
Test coverage
changes, or
Documentation
READMEs) were updated in this PRBehavior
Security