Allow k8s test to be run locally and clean up test issues #2582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cucumber Ruby does not natively implement the CUCUMBER_FILTER_TAGS environment variable. Instead, we must pass its value through the `--tags` Cucumber CLI argument.
This removes the warning log messages in the authn-k8s test output.
micahlee
force-pushed
the
run-k8s-tests-in-dev
branch
from
153b793 to
b5ca325
Compare
|
Code Climate has analyzed commit b5ca325 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 89.7% (-1.7% change). View more on Code Climate. |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desired Outcome
The desired outcome of this PR is to resolve issues in the k8s authenticator test suite causing regular build failures.
A side effect of this PR is to make it easier to run the GKE tests from a local development environment.
Implemented Changes
This PR:
Connected Issue/Story
In support of #2565
Changelog
CHANGELOG update
Test coverage
changes, or
Documentation
READMEs) were updated in this PRBehavior
Security