WIP: Policy lifecycle extensions #2666
Conversation
micahlee
force-pushed
the
policy_lifecycle_extension
branch
from
aeb2a2c to
20c1d58
Compare
micahlee
force-pushed
the
policy_lifecycle_extension
branch
from
20c1d58 to
5d7337d
Compare
![qlty-cloud-legacy[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| # frozen_string_literal: true | ||
|
|
||
| # Loads a policy into the database, by operating on a PolicyVersion which has already been created with the policy id, | ||
| require 'conjur/extension_repository' |
There was a problem hiding this comment.
File orchestrate.rb has 300 lines of code (exceeds 250 allowed). Consider refactoring.
| ) | ||
| end | ||
|
|
||
| def call(method, **kwargs) |
There was a problem hiding this comment.
Method call has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
|
|
||
| private | ||
|
|
||
| def require_extensions |
There was a problem hiding this comment.
Method require_extensions has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
|
|
||
| private | ||
|
|
||
| def require_extensions |
There was a problem hiding this comment.
Method require_extensions has 32 lines of code (exceeds 25 allowed). Consider refactoring.
| ) | ||
| end | ||
|
|
||
| def call(method, **kwargs) |
There was a problem hiding this comment.
Complex method Conjur::ExtensionRepository::ExtensionSet#call (26.6)
|
Code Climate has analyzed commit 5d7337d and detected 15 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 71.8% (50% is the threshold). This pull request will bring the total coverage in the repository to 89.8% (-1.7% change). View more on Code Climate. |
conjur-jenkins
force-pushed
the
master
branch
2 times, most recently
from
6566647 to
d65d499
Compare
conjur-jenkins
force-pushed
the
master
branch
from
d65d499 to
dbea020
Compare
conjur-jenkins
force-pushed
the
master
branch
from
dbea020 to
8031a2a
Compare
1 participant
Desired Outcome
Please describe the desired outcome for this PR. Said another way, what was
the original request that resulted in these code changes? Feel free to copy
this information from the connected issue.
Implemented Changes
Describe how the desired outcome above has been achieved with this PR. In
particular, consider:
Connected Issue/Story
Resolves #[relevant GitHub issue(s), e.g. 76]
CyberArk internal issue link: insert issue ID
Definition of Done
At least 1 todo must be completed in the sections below for the PR to be
merged.
Changelog
CHANGELOG update
Test coverage
changes, or
Documentation
READMEs) were updated in this PRBehavior
Security