Authn jwt refactor v5 #2990
Draft
Authn jwt refactor v5 #2990
+12,751
−10,169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit migrates the existing authn-jwt functionality to the new Strategy/ResolveIdentity architecture.
This commit updates the previously implemented authn-oidc workflow to adhere to the small changes in interface defined in the authn-jwt refactor
This commit removes the previous authn-jwt implementation and unit tests.
- Fix invalid escape key in CLI script - Specify single process in start script
Signed-off-by: Andy Tinkham <andy.tinkham@cyberark.com>
Signed-off-by: Andy Tinkham <andy.tinkham@cyberark.com>
Pub/Sub lib is injected into the Prometheus controller as the basis for metric updates and their triggers.
Remove the 'include Rack::Test::Methods' where it is not needed. Remove importing 'rack/test' since rack seems to be already loaded
This commit fixes an issue where an error was raised if an optional factory value was not present in the request body.
The previous implementation was causing errors to fill up the logs because Runit couldn't find a key file (which had been deleted).
Signed-off-by: Andy Tinkham <andy.tinkham@cyberark.com>
This commit migrates the existing authn-jwt functionality to the new Strategy/ResolveIdentity architecture.
This commit updates the previously implemented authn-oidc workflow to adhere to the small changes in interface defined in the authn-jwt refactor
This commit removes the previous authn-jwt implementation and unit tests.
This commit includes the functional code and tests for the Policy Factory feature.
This commit migrates the existing authn-jwt functionality to the new Strategy/ResolveIdentity architecture.
Contributor
|
@jvanderhoof Can this PR be closed? |
conjur-jenkins
force-pushed
the
master
branch
2 times, most recently
from
6566647 to
d65d499
Compare
conjur-jenkins
force-pushed
the
master
branch
from
d65d499 to
dbea020
Compare
conjur-jenkins
force-pushed
the
master
branch
from
dbea020 to
8031a2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
17 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desired Outcome
Please describe the desired outcome for this PR. Said another way, what was
the original request that resulted in these code changes? Feel free to copy
this information from the connected issue.
Implemented Changes
Describe how the desired outcome above has been achieved with this PR. In
particular, consider:
Connected Issue/Story
Resolves #[relevant GitHub issue(s), e.g. 76]
CyberArk internal issue ID: [insert issue ID]
Definition of Done
At least 1 todo must be completed in the sections below for the PR to be
merged.
Changelog
CHANGELOG update
Test coverage
changes, or
Documentation
READMEs) were updated in this PRBehavior
Security