Open
Conversation
added 3 commits
June 8, 2017 12:43
NON_DEFAULT doesn't seem to be working in the newer version.
In the case of Location.altitude (which is optional), not setting a
value results in the field not being ignored as it appearing in the
pass.json file:
{
"latitude" : 37.33182,
"longitude" : -122.03118,
"altitude" : "NaN"
}
This is not a valid format which results in the Wallet app not reading
the pass.
I changed Include.NON_DEFAULT to Include.NON_NULL and set the default
altitude value to null. This results in the same behaviour as before
the upgrade of Jackson.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NON_DEFAULT doesn't seem to be working in the newer version.
In the case of Location.altitude (which is optional), not setting a
value results in the field not being ignored as it appearing in the
pass.json file:
{
"latitude" : 37.33182,
"longitude" : -122.03118,
"altitude" : "NaN"
}
This is not a valid format which results in the Wallet app not reading
the pass.
I changed Include.NON_DEFAULT to Include.NON_NULL and set the default
altitude value to null. This results in the same behavior as before
the upgrade of Jackson.