Add support for /dev/fd/%u mountpoints #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The motivation follows libfuse's "Allow passing /dev/fuse file descriptor from parent process" 2018 commit: libfuse/libfuse@64e1107 Also remove a superfluous archive_entry_set_mode call that was (1) mistakenly passing st_mtime instead of st_mode and (2) immediately overwritten by a subsequent archive_entry_set_mode call. That superfluous call / typo was introduced in 2006 by commit 5bd0d35. It presumably never did anything noticable, so we remove it instead of trying to fix it.
Firsov62121
pushed a commit
to Firsov62121/archivemount
that referenced
this pull request
Jan 13, 2025
Firsov62121
pushed a commit
to Firsov62121/archivemount
that referenced
this pull request
Jan 13, 2025
Admittedly I haven't gotten this to actually mount but maybe bookwormoment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation follows libfuse's "Allow passing /dev/fuse file
descriptor from parent process" 2018 commit:
libfuse/libfuse@64e1107
Also remove a superfluous archive_entry_set_mode call that was (1)
mistakenly passing st_mtime instead of st_mode and (2) immediately
overwritten by a subsequent archive_entry_set_mode call. That
superfluous call / typo was introduced in 2006 by commit
5bd0d35. It presumably never did
anything noticable, so we remove it instead of trying to fix it.