set proper status to MantleBackup #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ushitora-anqou
force-pushed
the
update-mb-reconciliation
branch
from
9152d7c
to
3dc47d7
Compare
Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
ushitora-anqou
force-pushed
the
update-mb-reconciliation
branch
from
3dc47d7
to
8d51619
Compare
satoru-takeuchi
previously approved these changes
Sep 1, 2024
|
#32 is merged. Could you rebase this to main branch? |
|
I actually rebased this PR last week, and it looks like the CI started failing after that. I'll try to figure out what's going wrong. |
Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
ushitora-anqou
force-pushed
the
update-mb-reconciliation
branch
from
8d51619
to
79c269f
Compare
|
I think I could fix the bug. The code changes are as follows: https://github.com/cybozu-go/mantle/compare/8d5161972586d30281d7fcc9cafb0effa86855c8..79c269f46631a851f340d9aae6f457893af188a5 Well, it was a bug like a time bomb :( |
|
@satoru-takeuchi Could you review this again? |
satoru-takeuchi
approved these changes
Sep 2, 2024
|
Thank you for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.