Refactor MantleBackup reconciler #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PV is cluster resource, it is not needed. Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
toshipp
force-pushed
the
refactoring
branch
2 times, most recently
from
934e668
to
8722052
Compare
It is a rafactoring, no functional changes. Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
It is a refactoring, no functional changes. Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
toshipp
force-pushed
the
refactoring
branch
from
8722052
to
9ed211f
Compare
It is a refactoring, no functional changes. Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
The logic scattered in two position, dedup them to one on the Reconcile method for better understanding. Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
It is an error case, return err instead of nil. Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
To make Reconcile method small and ease understanding, move them into it. Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
It is more direct. Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
toshipp
force-pushed
the
refactoring
branch
from
9ed211f
to
1561bdb
Compare
It is used from controllers rather than NewMantleBackupReconciler. No functional changes. Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
We used the global logger in many places in spite of making custom loggers in Reconcilers. To fix it, add a parameter to give a logger and rename the global logger. Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
toshipp
force-pushed
the
refactoring
branch
from
1a292b2
to
3661d2c
Compare
satoru-takeuchi
requested review from
ushitora-anqou
and removed request for
satoru-takeuchi
ushitora-anqou
requested changes
Sep 18, 2024
The function not only create snap and update status but also add labels and check preconditions, so change the name to a more appropriate one. Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
ushitora-anqou
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see commit messages.