fix existing MantleBackup's reconciler for data replication #41
Conversation
ushitora-anqou
changed the title
| if backup1.Status.SnapID == nil || | ||
| *backup1.Status.SnapID < *backup.Status.SnapID && | ||
| backup1.ObjectMeta.DeletionTimestamp.IsZero() && | ||
| !meta.IsStatusConditionTrue(backup1.Status.Conditions, mantlev1.BackupConditionSyncedToRemote) { |
There was a problem hiding this comment.
The condition is OK. However, this situation is not an error like the failure of access to API servers but waiting for fullfilling some conditions. So, it's better to return from Reconcile() with ctrl.Result{Requeue: true}, nil. Probably the return value of replicate() should also be changed to distinguish whether the request will be requeued due to error or not.
I should be noticed this point in the previous PR which is to implementing replicate(). My fault.
…tion Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
ushitora-anqou
force-pushed
the
mantlebackup/fix-existing-impl
branch
from
6d291c3
to
a5039dd
Compare
|
@satoru-takeuchi @toshipp I fixed my code according to your reviews. Could you review this PR again? The changes are as follows: https://github.com/cybozu-go/mantle/compare/6d291c37d39095bca8d6a54db12329b5bd67aa63..a5039dd0cda8ae26cea5ce2343926c5881b49b0c |
Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
ushitora-anqou
force-pushed
the
mantlebackup/fix-existing-impl
branch
from
a5039dd
to
639088c
Compare
|
Thank you! |
No description provided.