Skip to content

Commit

Permalink
issue-686: disable mysql_native_password
Browse files Browse the repository at this point in the history
  • Loading branch information
shunki-fujita committed Jun 18, 2024
1 parent 429a3ac commit cd6beb1
Show file tree
Hide file tree
Showing 6 changed files with 0 additions and 8 deletions.
3 changes: 0 additions & 3 deletions pkg/mycnf/generator.go
Original file line number Diff line number Diff line change
Expand Up @@ -94,9 +94,6 @@ var DefaultMycnf = map[string]string{
// Disabled because of https://bugs.mysql.com/bug.php?id=104573
// The undo log truncate always fails on replica instances of `super_read_only = 1`.
"innodb_undo_log_truncate": "OFF",

// Disabled by default in MySQL 8.4
"loose_mysql_native_password": "ON",
}

// ConstMycnf is the mysqld configurations that MOCO applies forcibly.
Expand Down
1 change: 0 additions & 1 deletion pkg/mycnf/testdata/bufsize.cnf
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ long_query_time = 2
loose_binlog_transaction_compression = ON
loose_innodb_numa_interleave = ON
loose_innodb_validate_tablespace_paths = OFF
loose_mysql_native_password = ON
loose_replication_optimize_for_static_plugin_config = ON
loose_replication_sender_observe_commit_only = OFF
max_allowed_packet = 1G
Expand Down
1 change: 0 additions & 1 deletion pkg/mycnf/testdata/loose.cnf
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ log_slow_extra = ON
long_query_time = 2
loose_binlog_transaction_compression = ON
loose_innodb_validate_tablespace_paths = ON
loose_mysql_native_password = ON
loose_replication_optimize_for_static_plugin_config = ON
loose_replication_sender_observe_commit_only = OFF
loose_temptable_use_mmap = ON
Expand Down
1 change: 0 additions & 1 deletion pkg/mycnf/testdata/nil.cnf
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ long_query_time = 2
loose_binlog_transaction_compression = ON
loose_innodb_numa_interleave = ON
loose_innodb_validate_tablespace_paths = OFF
loose_mysql_native_password = ON
loose_replication_optimize_for_static_plugin_config = ON
loose_replication_sender_observe_commit_only = OFF
max_allowed_packet = 1G
Expand Down
1 change: 0 additions & 1 deletion pkg/mycnf/testdata/normalize.cnf
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ long_query_time = 2
loose_binlog_transaction_compression = ON
loose_innodb_numa_interleave = ON
loose_innodb_validate_tablespace_paths = OFF
loose_mysql_native_password = ON
loose_replication_optimize_for_static_plugin_config = ON
loose_replication_sender_observe_commit_only = OFF
max_allowed_packet = 1G
Expand Down
1 change: 0 additions & 1 deletion pkg/mycnf/testdata/opaque.cnf
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ long_query_time = 2
loose_binlog_transaction_compression = ON
loose_innodb_numa_interleave = ON
loose_innodb_validate_tablespace_paths = OFF
loose_mysql_native_password = ON
loose_replication_optimize_for_static_plugin_config = ON
loose_replication_sender_observe_commit_only = OFF
max_allowed_packet = 1G
Expand Down

0 comments on commit cd6beb1

Please sign in to comment.