Fix retry message when gathering mysqld status #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Masayuki Ishii <masa213f@gmail.com>
ymmt2005
reviewed
Aug 28, 2023
clustering/status.go
Outdated
Comment on lines
206
to
213
| logFromContext(ctx).Error(err, "failed to get mysqld status") | ||
| time.Sleep(statusCheckRetryInterval) | ||
| continue | ||
| if j == statusCheckRetryMax { | ||
| logFromContext(ctx).Error(err, "failed to get mysqld status, mysqld is not ready") | ||
| return | ||
| } else { | ||
| logFromContext(ctx).Error(err, "failed to get mysqld status, will retry") | ||
| time.Sleep(statusCheckRetryInterval) | ||
| continue | ||
| } |
There was a problem hiding this comment.
Since we have the following lines after for loop,
ss.MySQLStatus[index] = ist
returnI think it's more readable to change the code like:
if err == dbop.ErrNop {
return
}
if err == nil {
ss.MySQLStatus[index] = ist
return
}
// process errorsThere was a problem hiding this comment.
Thank you. I was wondering how to write.
I will use the style you suggested.
Signed-off-by: Masayuki Ishii <masa213f@gmail.com>
ymmt2005
reviewed
Aug 28, 2023
Co-authored-by: Yamamoto, Hirotaka <ymmt2005@gmail.com>
Signed-off-by: Masayuki Ishii <masa213f@gmail.com>
This reverts commit 40d0144.
ymmt2005
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the retry message when gathering mysqld status.
The current error message is confusing whether it's in retrying or MySQL is finally treated as Not-Ready.
Signed-off-by: Masayuki Ishii masa213f@gmail.com