Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue-708: Long wait for SetReadOnly to complete #717

Closed
wants to merge 6 commits into from
Closed

issue-708: Long wait for SetReadOnly to complete #717

wants to merge 6 commits into from

Conversation

shunki-fujita
Copy link
Contributor

@shunki-fujita shunki-fujita changed the title issue-787: add switchover test issue-787: Long wait for SetReadOnly to complete Jul 4, 2024
@shunki-fujita shunki-fujita force-pushed the issue-708 branch 4 times, most recently from 964bacd to 9d64b7a Compare July 5, 2024 08:42
@shunki-fujita shunki-fujita changed the title issue-787: Long wait for SetReadOnly to complete issue-708: Long wait for SetReadOnly to complete Jul 8, 2024
@shunki-fujita shunki-fujita force-pushed the issue-708 branch 2 times, most recently from 815af7f to 5c74c23 Compare July 8, 2024 07:03
ymmt2005
ymmt2005 reviewed Jul 8, 2024
View reviewed changes
clustering/operations.go Outdated Show resolved Hide resolved
@shunki-fujita shunki-fujita force-pushed the issue-708 branch 6 times, most recently from 47bdf0f to 9b64073 Compare July 8, 2024 10:16
@shunki-fujita shunki-fujita marked this pull request as draft July 9, 2024 01:21
@shunki-fujita shunki-fujita force-pushed the issue-708 branch 3 times, most recently from 83da316 to 62b360f Compare July 9, 2024 04:29
@shunki-fujita shunki-fujita marked this pull request as ready for review July 9, 2024 04:40
@shunki-fujita shunki-fujita force-pushed the issue-708 branch 2 times, most recently from baadcc7 to 4981d14 Compare July 9, 2024 05:02
@shunki-fujita shunki-fujita marked this pull request as draft July 9, 2024 05:26
@shunki-fujita shunki-fujita marked this pull request as ready for review July 9, 2024 09:08
ymmt2005
ymmt2005 reviewed Jul 9, 2024
View reviewed changes
clustering/operations.go Outdated Show resolved Hide resolved
ymmt2005
ymmt2005 reviewed Jul 9, 2024
View reviewed changes
clustering/operations.go Outdated Show resolved Hide resolved
ymmt2005
ymmt2005 previously approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@ymmt2005 ymmt2005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ymmt2005
ymmt2005 reviewed Jul 9, 2024
View reviewed changes
clustering/operations.go Outdated Show resolved Hide resolved
ymmt2005
ymmt2005 previously approved these changes Jul 10, 2024
View reviewed changes
@shunki-fujita shunki-fujita force-pushed the issue-708 branch 3 times, most recently from 88dd26d to 76df80e Compare July 10, 2024 11:17
@shunki-fujita shunki-fujita marked this pull request as draft August 1, 2024 08:40
@shunki-fujita
Copy link
Contributor Author

The problem is that the switching is not completed within the PreStopSeconds time.
Solution will be considered separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ymmt2005 ymmt2005 ymmt2005 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shunki-fujita @ymmt2005