add or change k8s v1.27 #54
Merged
+251
−306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmdkuk
reviewed
Oct 23, 2023
kmdkuk
reviewed
Oct 26, 2023
| @@ -497,6 +498,7 @@ kind: Pod` | |||
| }) | |||
|
|
|||
| It("should recreate the service resource when the service resource is deleted", func() { | |||
|
|
|||
There was a problem hiding this comment.
Is this empty line intentional?
There was a problem hiding this comment.
Not, I will delete this line.
Comment on lines
+9
to
+11
| k8s.io/api v0.28.3 | ||
| k8s.io/apimachinery v0.28.3 | ||
| k8s.io/client-go v0.28.3 |
There was a problem hiding this comment.
It is desirable to use the latest version of 0.27.Z for these three packages.
There was a problem hiding this comment.
It had automatically updated due to depend on the version of the runtime-controller.
| }}, | ||
| expected: []statusResponse{ | ||
| {Jobs: []job{{Name: "test1", Status: "Failed"}, {Name: "test2", Status: "Pending"}}}, | ||
| {Jobs: []job{{Name: "test7", Status: "Failed"}, {Name: "test8", Status: "Pending"}}}, |
There was a problem hiding this comment.
Why did you make the test names a sequential number?
I thought there would be no problem if Name was unique within each []Job.
There was a problem hiding this comment.
Yes, it is unesessary update, but it bring us easy identify test reult when we confuse which case failed.
Co-authored-by: kouki kamada <kouworld0123@gmail.com>
kmdkuk
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.