Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iDRAC9 F/W ver up and RedFish ver up #88

Merged
merged 21 commits into from
Jul 19, 2023
Merged

iDRAC9 F/W ver up and RedFish ver up #88

merged 21 commits into from
Jul 19, 2023

Conversation

takara9
Copy link
Contributor

@takara9 takara9 commented Jul 10, 2023

OMSA: ver up 10.2.0.0 -> 11.0.0.0
Change Base Image : CentOS7 -> Ubuntu 22.04

@takara9 takara9 self-assigned this Jul 10, 2023
Metrics:
- Path: /redfish/v1/Chassis/System.Embedded.1/NetworkAdapters/NIC.Embedded.1
Properties:
- Name: chassis_systemembedded1_networkadapters_nicembedded1_status_health
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not change the metric name. Compatibility is lost.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reworked the rules for redfish v1.17 based on your comments.

- /Assembly#/
- /redfish/v1/Chassis/$
Metrics:
- Path: /redfish/v1/Chassis/System.Embedded.1/NetworkAdapters/NIC.Embedded.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use placeholders as follows:
/redfish/v1/Chassis/{chassis}/NetworkAdapters/{nic}

Placeholders are used as labels for metrics.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reworked the rules for redfish v1.17 based on your comments.

- Name: chassis_systemembedded1_powersubsystem_powersupplies_metrics_status_state
Pointer: /Status/State
Type: state
- Path: /redfish/v1/Chassis/System.Embedded.1/Sensors/{fan.embedded}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not include . in placeholders.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reworked the rules for redfish v1.17 based on your comments.

- Name: chassis_systemembedded1_networkadapters_nicembedded1_status_state
Pointer: /Status/State
Type: state
- Path: /redfish/v1/Chassis/System.Embedded.1/NetworkAdapters/NIC.Embedded.1/NetworkDeviceFunctions/{nic-dev-id}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not include - in placeholders.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reworked the rules for redfish v1.17 based on your comments.

CHANGELOG.md Outdated Show resolved Hide resolved
docker/systemctl-dummy Outdated Show resolved Hide resolved
docker/Dockerfile Outdated Show resolved Hide resolved
docker/Dockerfile Outdated Show resolved Hide resolved
docker/Dockerfile Outdated Show resolved Hide resolved
docker/Dockerfile Outdated Show resolved Hide resolved
redfish/rules/dell_redfish_1.17.0.yml Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
docker/Dockerfile Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docker/Dockerfile Outdated Show resolved Hide resolved
base-rules/dell-redfish-v117.yaml Outdated Show resolved Hide resolved
base-rules/dell-redfish-v117.yaml Show resolved Hide resolved
base-rules/dell-redfish-v117.yaml Outdated Show resolved Hide resolved
base-rules/dell-redfish-v117.yaml Show resolved Hide resolved
redfish/rules/rule.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@morimoto-cybozu morimoto-cybozu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@takara9 takara9 merged commit e688b27 into main Jul 19, 2023
@takara9 takara9 deleted the dsu-latest branch July 19, 2023 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants