-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iDRAC9 F/W ver up and RedFish ver up #88
Conversation
Metrics: | ||
- Path: /redfish/v1/Chassis/System.Embedded.1/NetworkAdapters/NIC.Embedded.1 | ||
Properties: | ||
- Name: chassis_systemembedded1_networkadapters_nicembedded1_status_health |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not change the metric name. Compatibility is lost.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reworked the rules for redfish v1.17 based on your comments.
- /Assembly#/ | ||
- /redfish/v1/Chassis/$ | ||
Metrics: | ||
- Path: /redfish/v1/Chassis/System.Embedded.1/NetworkAdapters/NIC.Embedded.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use placeholders as follows:
/redfish/v1/Chassis/{chassis}/NetworkAdapters/{nic}
Placeholders are used as labels for metrics.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reworked the rules for redfish v1.17 based on your comments.
- Name: chassis_systemembedded1_powersubsystem_powersupplies_metrics_status_state | ||
Pointer: /Status/State | ||
Type: state | ||
- Path: /redfish/v1/Chassis/System.Embedded.1/Sensors/{fan.embedded} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not include .
in placeholders.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reworked the rules for redfish v1.17 based on your comments.
- Name: chassis_systemembedded1_networkadapters_nicembedded1_status_state | ||
Pointer: /Status/State | ||
Type: state | ||
- Path: /redfish/v1/Chassis/System.Embedded.1/NetworkAdapters/NIC.Embedded.1/NetworkDeviceFunctions/{nic-dev-id} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not include -
in placeholders.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reworked the rules for redfish v1.17 based on your comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
OMSA: ver up 10.2.0.0 -> 11.0.0.0
Change Base Image : CentOS7 -> Ubuntu 22.04