Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue fix 1.40.0 #90

Merged
merged 2 commits into from
Jul 20, 2023
Merged

Issue fix 1.40.0 #90

merged 2 commits into from
Jul 20, 2023

Conversation

takara9
Copy link
Contributor

@takara9 takara9 commented Jul 20, 2023

No description provided.

@takara9 takara9 self-assigned this Jul 20, 2023
morimoto-cybozu
morimoto-cybozu approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@morimoto-cybozu morimoto-cybozu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I've confirmed that the setup-hw container is executed (1) with the "--privileged" option and (2) with "/dev" and "/lib/modules" mounted.
"/lib/modules" is mounted in the read-only mode, but I guess it would be OK.

@takara9 takara9 merged commit a737584 into main Jul 20, 2023
1 check passed
@takara9 takara9 deleted the issue-fix-1.40.0 branch July 20, 2023 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morimoto-cybozu morimoto-cybozu morimoto-cybozu approved these changes

@zoetrope zoetrope Awaiting requested review from zoetrope

Assignees

@takara9 takara9

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@takara9 @morimoto-cybozu