Early close file descriptors #94
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves #93. `cybozu::resource` now keeps the file descriptor private and adds a new private method `close()` to close the file descriptor from the friend class `cybozu::reactor`. Subclasses can get the file descriptor via `int fileno()` method that returns -1 after closed. `cybozu::reactor` calls `cybozu::resource::close` when it removes the resource from the active set of resources and puts it to the pending destruction list. By this, the file descriptor of the closed resource is closed earlier. Other classes are updated to reference `fileno()`.
|
replaced by #95 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #93.
cybozu::resourcenow keeps the file descriptor private and addsa new private method
close()to close the file descriptor fromthe friend class
cybozu::reactor. Subclasses can get the filedescriptor via
int fileno()method that returns -1 after theresource is invalidated.
cybozu::reactorcallscybozu::resource::closewhen it removesthe resource from the active set of resources and puts it to the
pending destruction list. By this, the file descriptor of the
invalidated resource is closed earlier.
Other classes are updated to reference
fileno().