Migrate rust sp #79
Draft
Migrate rust sp #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move Updated to core Remove dummy implementation of get_input_hashes Remove dead code Heavy refactoring
Owner
|
I agree with this concept, though I still haven't looked at the workspace PR too in-depth to make a proper judgement. I'd like to dedicate some time to SPDK (this PR but also the workspace one in general), once the dana address stuff is merged and released. Either way, I agree that it's probably good idea to unite the crates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A proposal to move the whole cygnet3/rust-silentpayments#110 crate inside
spdkas aprotocolmodule.sp-addressin its own crate so that project that only need silent payment address parsing can do it without pulling a lot of dependenciesspdk-corewith only a subset of features: sending/receiving only, scanner without sending, full wallet...rust-silentpaymentwhen libsecp module will get mergedNot sure if it's the right approach so getting feedback on that design first.