Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinclude shinyMobile blog post #58

Merged
merged 11 commits into from
Sep 5, 2024
Merged

Reinclude shinyMobile blog post #58

merged 11 commits into from
Sep 5, 2024

Conversation

DivadNojnarg
Copy link
Collaborator

No description provided.

@@ -30,6 +30,7 @@ jobs:
any::rmarkdown
any::downlit
any::xml2
any::shinyMobile
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get why I have to do this to make it work @christophsax. The shinylive apps needs shinyMobile as a dependency to work. The thing is that we talk about 2 different things: doing this will tell pak to install the R package in the runner R library. The shinylive apps need the wasm version which isn't the one we installed with pak (basically, it is provided by the webR wasm CRAN or any other custom CRAN with the help of https://github.com/r-wasm/rwasm). Do you have any idea @georgestagg?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats to the ✅ 🎉🎉🎉

@DivadNojnarg DivadNojnarg merged commit 7ab3566 into main Sep 5, 2024
1 check passed
@DivadNojnarg DivadNojnarg deleted the shinylive-issue-patch branch September 5, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants